Skip to content

add cuda 13.3 CI job and workaround for typename decltype issue in cuda 13.3 - #2076

Merged
yhmtsai merged 7 commits into
developfrom
add_fix_cuda13.3
Aug 25, 2026
Merged

add cuda 13.3 CI job and workaround for typename decltype issue in cuda 13.3#2076
yhmtsai merged 7 commits into
developfrom
add_fix_cuda13.3

Conversation

@yhmtsai

@yhmtsai yhmtsai commented Aug 24, 2026

Copy link
Copy Markdown
Member

This PR adds cuda 13.3 CI job and add workaround for typename decltype issue in cuda 13.3
@lahwaacz have created a reproducer in #2031 and reported it to NVIDIA

some error log from nvcc before the fix.

error: need ‘typename’ before ‘decltype (gko::batch::solver::enable_preconditioned_iterative_solver_factory_parameters<Parameters, Factory>::preconditioner)::element_type’ because ‘decltype (gko::batch::solver::enable_preconditioned_iterative_solver_factory_parameters<Parameters, Factory>::preconditioner)’ is a dependent scope

when we use typename decltype(_name)::element_type

close #2031

the original plan is to use

template <typename T>
using element_type_t = typename T::element_type

works fine with cuda 13.3 but cuda 13.1 complains about that.
cuda 13.1 somehow gets IsaiType. so I need to create a struct for that. (corresponding error log: https://gitlab.com/ginkgo-project/ginkgo-public-ci/-/jobs/16069682644)

TODO:

@yhmtsai yhmtsai self-assigned this Aug 24, 2026
@ginkgo-bot ginkgo-bot added the reg:ci-cd This is related to the continuous integration system. label Aug 24, 2026
@yhmtsai yhmtsai added the 1:ST:ready-for-review This PR is ready for review label Aug 24, 2026
@yhmtsai
yhmtsai requested review from MarcelKoch and pratikvn August 24, 2026 09:56

@pratikvn pratikvn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread include/ginkgo/core/base/abstract_factory.hpp
@yhmtsai yhmtsai added 1:ST:ready-to-merge This PR is ready to merge. and removed 1:ST:ready-for-review This PR is ready for review labels Aug 25, 2026
@yhmtsai
yhmtsai merged commit 69ab75c into develop Aug 25, 2026
18 of 19 checks passed
@yhmtsai
yhmtsai deleted the add_fix_cuda13.3 branch August 25, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1:ST:ready-to-merge This PR is ready to merge. 1:ST:run-full-test reg:ci-cd This is related to the continuous integration system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nvcc regression in CUDA 13.3

3 participants